Skip to content

usbdev: re-assert soft connect in cdcecm/cdcncm disconnect() #19371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricardgb wants to merge 2 commits into
base: master
Choose a base branch
from
+22 −0
Open

usbdev: re-assert soft connect in cdcecm/cdcncm disconnect() #19371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
746458f
usbdev: re-assert soft connect in cdcecm/cdcncm disconnect()
ricardgb Jul 8, 2026
4e3426e
Update drivers/usbdev/cdcncm.c
ricardgb Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions drivers/usbdev/cdcecm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1916,6 +1916,17 @@ static void cdcecm_disconnect(FAR struct usbdevclass_driver_s *driver,
FAR struct usbdev_s *dev)
{
uinfo("\n");

/* Perform the soft connect function so that we will we can be

@xiaoxiang781216 xiaoxiang781216 Jul 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* Perform the soft connect function so that we will we can be
/* Perform the soft connect function so that we can be

* re-enumerated (unless we are part of a composite device). The USB
* device controller calls CLASS_DISCONNECT() on every bus reset, which
* is the first step of any enumeration, so without this the device is
* left soft-disconnected and never enumerates on the host.
*/

#ifndef CONFIG_CDCECM_COMPOSITE
DEV_CONNECT(dev);
#endif
}

/****************************************************************************
Expand Down
11 changes: 11 additions & 0 deletions drivers/usbdev/cdcncm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2868,6 +2868,17 @@ static void cdcncm_disconnect(FAR struct usbdevclass_driver_s *driver,

cdcncm_resetconfig(self);
uinfo("\n");

/* Perform the soft connect function so that we can be
* re-enumerated (unless we are part of a composite device). The USB
* device controller calls CLASS_DISCONNECT() on every bus reset, which
* is the first step of any enumeration, so without this the device is
* left soft-disconnected and never enumerates on the host.
*/

#ifndef CONFIG_CDCNCM_COMPOSITE
DEV_CONNECT(dev);
#endif
}

/****************************************************************************
Expand Down
Loading