crypto/cryptosoft: Add support for PBKDF2#18608
crypto/cryptosoft: Add support for PBKDF2#18608PruteanuVlad wants to merge 1 commit intoapache:masterfrom
Conversation
|
Hi, thanks for adding PBKDF2 support — this is a useful addition to the crypto stack! I have a few suggestions below, mostly around cleanup.
|
|
Hi @PruteanuVlad please fix |
acassis
left a comment
There was a problem hiding this comment.
@PruteanuVlad please update the Documentation to include this algorithm as supported
This adds support for PBKDF2 (SHA1 and SHA256) while leveraging the existing infrastructure for HMAC. Signed-off-by: Vlad Pruteanu <pruteanuvlad1611@yahoo.com>
ea44e3d to
dbfd5e2
Compare
|
Thanks for the review 😄 |
Summary
This adds support for PBKDF2 (SHA1 and SHA256) while leveraging the existing infrastructure for HMAC.
I tried to take advantage of the existing HMAC code as much as possible.
Test app has been added in this PR: apache/nuttx-apps#3437
Modified files:
boards/xtensa/esp32/esp32-devkitc/configs/crypto/defconfig - enables the test app
crypto/cryptodev.c - treats the new PBKDF2 cases and handles new struct field
crypto/cryptosoft.c - handles the actual algorithm implementation
include/crypto/cryptodev.h - new defines for pbkdf2
Impact
This allows users to derive keys using PBKDF2.
##Testing
Development was done using ESP32 DevkitC.
Building was done on Ubuntu 24.04 VM.
For testing, I ran the PBKDF2 test from the PR mentioned above.