arch/intel64: add CPU affinity support for irq#18602
Open
raiden00pl wants to merge 1 commit intoapache:masterfrom
Open
arch/intel64: add CPU affinity support for irq#18602raiden00pl wants to merge 1 commit intoapache:masterfrom
raiden00pl wants to merge 1 commit intoapache:masterfrom
Conversation
github-actions
bot
added
Arch: x86_64
add CPU affinity support for interrupts (up_affinity_irq) Signed-off-by: p-szafonimateusz <p-szafonimateusz@xiaomi.com>
simbit18
requested review from
acassis,
anchao,
linguini1,
michallenc,
wangchdo and
xiaoxiang781216
xiaoxiang781216
approved these changes
Mar 25, 2026
anchao
requested changes
Mar 25, 2026
| if (CPU_ISSET(cpu, &cpuset)) | ||
| { | ||
| data = x86_64_cpu_to_loapic(cpu) << 24; | ||
| up_ioapic_write(IOAPIC_REG_TABLE + (irq - IRQ0) * 2 + 1, data); |
Contributor
There was a problem hiding this comment.
Suggested change
| up_ioapic_write(IOAPIC_REG_TABLE + (irq - IRQ0) * 2 + 1, data); | |
| flags = spin_lock_irqsave(&g_irq_spinlock); | |
| up_ioapic_write(IOAPIC_REG_TABLE + (irq - IRQ0) * 2 + 1, data); | |
| spin_unlock_irqrestore(&g_irq_spinlock, flags); |
Maybe we can narrow the lock scope.
linguini1
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arch/intel64: add CPU affinity support for irq
Impact
required for intel64 to compile with this change #18601
Testing
ctucanfd on intel64 works with this change #18601