Skip to content

v4l2/video: backport sim camera and v4l2 improvements#18353

Open
nyh163925 wants to merge 16 commits intoapache:masterfrom
nyh163925:sync_v4l2_form_vela
Open

v4l2/video: backport sim camera and v4l2 improvements#18353
nyh163925 wants to merge 16 commits intoapache:masterfrom
nyh163925:sync_v4l2_form_vela

Conversation

@nyh163925
Copy link

@nyh163925 nyh163925 commented Feb 5, 2026

Summary

  • Backport selected downstream updates for V4L2/Video and Sim Camera.
  • Adds pixel-format enumeration to sim camera and extends V4L2 M2M capabilities (userptr, multi-planar, queue handling).
  • Improves V4L2 capture behavior and adds entropy stream format support.
  • Includes stability fixes for bounds checking, leaks, and Coverity issues in V4L2/V4L2 M2M.
  • No Drop/Skip items from the sync plan are included.

Impact

  • Feature: YES — expands V4L2 M2M and sim camera functionality.
  • Build: NO — no build system changes required for users.
  • Hardware: YES — affects video/V4L2 drivers and sim camera behavior.
  • Compatibility: YES — new formats/modes are additive; existing behavior remains.
  • Testing

yangyalei and others added 16 commits February 4, 2026 15:42
@nyh163925
nuttx/v4l2: Fix array access out of bounds
dcfb884 
Change-Id: Icfc435a07a276543c27e0c2e360a5587d093e3ba
Signed-off-by: yangyalei <yangyalei@xiaomi.com>
Signed-off-by: yaojingwei <yaojingwei@xiaomi.com>
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@nyh163925
nuttx/v4l2: add v4l2 standard define for libcamera.
300ab71 
Change-Id: I0813746411fdde8324b2998958edeeecc2a4bdd4
Signed-off-by: yangyalei <yangyalei@xiaomi.com>
Signed-off-by: yaojingwei <yaojingwei@xiaomi.com>
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@nyh163925
v4l2_cap: support V4L2_PIX_FMT_ENTROPY pix fmt for private entropy
b3fe34a 
encode stream.

Change-Id: I44e769d5978ba11aa92ab93b86c8c0b0330d2623
Signed-off-by: yaojingwei <yaojingwei@xiaomi.com>
(cherry picked from commit 47da3874bfddcacb8ea648a018a59ab51ecb200a)
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@nyh163925
v4l2_cap: support set buffer size by s_fmt command.
e7f2f39 
For some encode stream, the buffer size need to be set by user.

Change-Id: I7b868c7c24aea49839fa2427ceca74f1e77942fc
Signed-off-by: yaojingwei <yaojingwei@xiaomi.com>
(cherry picked from commit 12cdf72f9f6542a9a0454bd871c4595bf0fde0ff)
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@nyh163925
nuttx/video: support driver define memory handle for v4l2_m2m.
88c05f5 
Change-Id: I75d52e8f8efa6b7108561e5b830e94ac8c4c2439
Signed-off-by: yaojingwei <yaojingwei@xiaomi.com>
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@nyh163925
v4l2_cap: fix reqbuf return error when set count = 0.
0ef37be 
Change-Id: I86fecb05edb16bb20cefab1236c8c6a33d2e8e1e
Signed-off-by: yaojingwei <yaojingwei@xiaomi.com>
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@nyh163925
v4l2_m2m: fix codec_file_s variable leaks
a3d9033 
Change-Id: If5c17a437c1cd8cbe349cf7130883553fa4fd2dd
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@nyh163925
sys/videoio: add more v4l2-buffer flag form linux/videodev2.h
14e6847 
Change-Id: I24ad34a2e290b85112b0db46f8e90be03f8a7416
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@nyh163925
drivers/video: optimize critical section.
e9df7b1 
use spin/mutex lock to replace critial section.

Change-Id: I67c1cde1e9f212fde683b3b2e027f787d92a1170
Signed-off-by: yaojingwei <yaojingwei@xiaomi.com>
@nyh163925
v4l2_m2m: limit capture/output queue number to driver`s ability
eeb117b 
Change-Id: I982dc13a7eb39d608977e2d8fa4ae8905c7e0a9e
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@nyh163925
v4l2-m2m: add driver`s support memory mode check
b656c31 
Change-Id: I084094343715571af2bd47782bc2ada0a9ef8089
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@nyh163925
v4l2_m2m: Add vaddr field to v4l2-buffer to interact with driver's re…
a72d657 
…al address

Change-Id: I3d8a30233935d6b3114e3188ce16699134e68b86
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@nyh163925
v4l2-m2m: support mplanes format
07a5080 
Change-Id: I84596baa0e8cbd9b8eb0c67e143af6f86d1ec999
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@nyh163925
v4l2-m2m: support userptr mode
45d912a 
Change-Id: I3873781d82dc0981c493acfd1a3748c2e20e94b2
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@nyh163925
v4l2_m2m: fix coverity issues
8609d69 
CID 8306850: uninit_use

Change-Id: Ic9fd562b0aacf9f7e3951e1cc4b6f03ceba2be5a
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@nyh163925
sim_camera: support enum pixel format.
01877a0 
Change-Id: I13af8c8fe86635d63e0d952857458d705ef49691
Signed-off-by: yaojingwei <yaojingwei@xiaomi.com>
Signed-off-by: niyinghao <niyinghao@xiaomi.com>
@github-actions github-actions bot added Arch: simulator Issues related to the SIMulator Area: Video Size: L The size of the change in this PR is large labels Feb 5, 2026
jerpelea
jerpelea requested changes Feb 5, 2026
View reviewed changes
Copy link
Contributor

@jerpelea jerpelea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please split the PR in logical separate PRs
ex:
enhancement
fixes
sim camera backport

Thanks

@acassis
Copy link
Contributor

acassis commented Feb 7, 2026

@nyh163925 please fix these issues:

../nuttx/tools/checkpatch.sh -c -u -m -g 877a9af..HEAD
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Missing git commit message
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Missing git commit message
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Missing git commit message
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Missing git commit message
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Missing git commit message
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Missing git commit message
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Remove Gerrit Change-ID's before submitting upstream
❌ Remove Gerrit Change-ID's before submitting upstream
Used config files:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerpelea jerpelea jerpelea requested changes

@xiaoxiang781216 xiaoxiang781216 Awaiting requested review from xiaoxiang781216 xiaoxiang781216 is a code owner

@pkarashchenko pkarashchenko Awaiting requested review from pkarashchenko pkarashchenko is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Arch: simulator Issues related to the SIMulator Area: Video Size: L The size of the change in this PR is large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nyh163925 @acassis @jerpelea