NIFI-15561: Do not consider references from Ghosted components in Par…#10865
NIFI-15561: Do not consider references from Ghosted components in Par…#10865markap14 wants to merge 2 commits intoapache:mainfrom
Conversation
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for addressing this issue and providing detailed tests for the change @markap14. Skipping the Parameter reference checks for missing extensions seems like a straightforward and reasonable change at the framework level given the totality of the impact.
I noted two minor recommendations on the test classes. The branch commits also need to be signed.
|
|
||
| // Verify processor is VALID | ||
| getClientUtil().waitForValidProcessor(processorId); | ||
| logger.info("Processor {} is VALID with non-sensitive parameter value 'hello'", processorId); |
There was a problem hiding this comment.
Most of the system test do not have local logging, it seems like most or all of the test logging should be removed.
There was a problem hiding this comment.
Agreed that most system tests don't have much of any logging. But I don't think I would agree that is advantageous. I've found of late that adding this type of logging can be valuable when troubleshooting because the timestamps can be easily correlated with the timestamps in the nifi-app.log, nifi-user.log, etc. making it easier to understand what happened. I also find it's helpful when running tests manually from an IDE, if things are taking a bit and especially if it gets "stuck" for some reason it makes it much more clear what's happening. So I think rather than stripping out all of the logging here we need to consider adding in more logging to the system tests going forward.
| final ParameterContext context = createStandardParameterContext(referenceManager); | ||
|
|
||
| final ProcessorNode procNode = getProcessorNode("abc", referenceManager); | ||
| Mockito.when(procNode.isExtensionMissing()).thenReturn(true); |
There was a problem hiding this comment.
I recommend replacing the qualified Mockito.when and Mockito.mock() references with static imports.
…ameter reference sensitivity checks
2 participants
…ameter reference sensitivity checks
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation