NIFI-15393 Fix login redirect to preserve original URL#10698
Open
naman-shukla-ksolves wants to merge 2 commits intoapache:mainfrom
Open
NIFI-15393 Fix login redirect to preserve original URL#10698naman-shukla-ksolves wants to merge 2 commits intoapache:mainfrom
naman-shukla-ksolves wants to merge 2 commits intoapache:mainfrom
Conversation
exceptionfactory
requested changes
Dec 29, 2025
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for proposing this improvement @naman-shukla-ksolves.
From a procedural perspective, please sign all Git commits and force-push to the branch for verification.
Regarding the substantive change, I will defer to others with more perspective on the frontend, but direct reference to sessionStorage seems questionable. At minimum, having a shared service abstraction seems safer than relying on decoupled references to a common item key.
4bb39bd to
c989e3b
Compare
Author
|
@pvillard31 Thank you for the feedback. I've addressed both points:
Please review when you have a chance. |
c989e3b to
c81552f
Compare
… before redirecting to the login page, causing users to lose their intended destination after successful authentication
c81552f to
31b39e8
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15393
Fixed login redirect issue where users were redirected to the home screen instead of their originally requested URL after authentication. The authentication flow now preserves the original destination URL and redirects users appropriately after login.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-15393NIFI-15393Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation