MINIFICPP-2668 Move standard processor tests to modular docker tests#2061
Closed
lordgamez wants to merge 2 commits intoapache:MINIFICPP-2666from
Closed
MINIFICPP-2668 Move standard processor tests to modular docker tests#2061lordgamez wants to merge 2 commits intoapache:MINIFICPP-2666from
lordgamez wants to merge 2 commits intoapache:MINIFICPP-2666from
Conversation
5e51067 to
1b11558
Compare
8 tasks
b6a74cc to
67bf898
Compare
e172fa7 to
2640d9b
Compare
67bf898 to
d86d34a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates standard processor tests from the legacy docker integration test framework to the newer modular behave-based test framework. The changes consolidate testing infrastructure by removing duplicate processor implementations and container classes from the old framework.
Key changes:
- Adds new container implementations (TcpClientContainer, DiagSlave) to the modular test framework
- Updates 8 feature files to use the new framework's syntax and step definitions
- Removes deprecated processor and container classes from the old docker integration framework
- Extends the behave framework with new step definitions and helper methods
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tcp_client_container.py | New TCP client container for network listener tests |
| diag_slave_container.py | New DiagSlave container for Modbus testing |
| steps.py | Adds step definitions for PLC/Modbus and TCP client setup |
| *.feature files (8 files) | Migrated to new framework syntax with updated assertions |
| environment.py | Adds platform detection for x86/x64-only tests |
| core_steps.py | New steps for file creation and FIPS mode |
| checking_steps.py | New assertion steps for JSON and empty file validation |
| container.py | Enhanced with JSON validation and debug print statement |
| minifi_container.py | Adds FIPS mode support |
| Old framework files | Removes deprecated processor/container implementations |
Comments suppressed due to low confidence (1)
extensions/standard-processors/tests/features/defragtextflowfiles.feature:42
- The expected output appears to have changed from having one '<1>,' to two '<1>,<1>,' at the beginning. This change affects multiple test scenarios (lines 42 and 69). Ensure this change reflects the actual expected behavior and that corresponding tests verify this is correct, as this could indicate a change in how the DefragmentText processor handles end-of-message patterns.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f4bbe06 to
5a197d8
Compare
2640d9b to
985912c
Compare
5a197d8 to
667d6bd
Compare
szaszm
reviewed
Dec 3, 2025
fgerlits
reviewed
Dec 5, 2025
985912c to
74f9297
Compare
667d6bd to
ac43cb9
Compare
fgerlits
approved these changes
Jan 6, 2026
szaszm
approved these changes
Jan 7, 2026
martinzink
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2668
Depends on #2059
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.