Skip to content

Don't pass removed -Djava.endorsed.dirs when running app clients #9446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renatsaf wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −5
Open

Don't pass removed -Djava.endorsed.dirs when running app clients #9446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions ...ise/glassfish.javaee/src/org/netbeans/modules/glassfish/javaee/Hk2JavaEEPlatformImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,11 +766,26 @@ public String getToolProperty(String toolName, String propertyName) {
if (J2eePlatform.TOOL_PROP_JVM_OPTS.equals(propertyName)) {
if(domainPath != null) {
StringBuilder sb = new StringBuilder();
sb.append("-Djava.endorsed.dirs=");
sb.append(quotedString(new File(root,"lib/endorsed").getAbsolutePath()));
sb.append(File.pathSeparator);
sb.append(quotedString(new File(root,"modules/endorsed").getAbsolutePath()));
sb.append(" -javaagent:");
// The endorsed standards mechanism (-Djava.endorsed.dirs) was
// removed in JDK 9 (JEP 220); passing it aborts JVM startup.
// Only emit it for the endorsed directories that actually exist
// (legacy servers on JDK 8 or earlier); modern GlassFish ships
// none, so the option is omitted and the app client can run on
// JDK 9+.
StringBuilder endorsedDirs = new StringBuilder();
for (String endorsedDir : new String[] {"lib/endorsed", "modules/endorsed"}) { // NOI18N
File dir = new File(root, endorsedDir);
if (dir.isDirectory()) {
if (endorsedDirs.length() > 0) {
endorsedDirs.append(File.pathSeparator);
}
endorsedDirs.append(quotedString(dir.getAbsolutePath()));
}
}
if (endorsedDirs.length() > 0) {
sb.append("-Djava.endorsed.dirs=").append(endorsedDirs).append(' '); // NOI18N
}
sb.append("-javaagent:");
String url = dm.getCommonServerSupport().getInstanceProperties().get(GlassfishModule.URL_ATTR);
File f = new File(root,"lib/gf-client.jar"); // NOI18N
if (f.exists()) {
Expand Down