Skip to content

Conversation

@lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Dec 18, 2025

When debugger evaluates watches, it sometimes interprets the watch, but if the watch is too complex, it will synthetize a class with the watch, compile, load and execute it.

When compiling the class, it will gather the ClassPath, but it bases that step on the source root, not on the relevant file. As a consequence if ClassPath for file and directory differs, there may be a problem when compiling the synthetized class. This may happen e.g. for OpenJDK tests, that don't have ClassPath for source roots.

The proposal here is to simply read the ClassPath from the relevant file, not the directory.


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

…ith cases where files have classpath, but directories don't.
@lahodaj lahodaj added this to the NB29 milestone Dec 18, 2025
@lahodaj lahodaj added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Dec 18, 2025
@lahodaj lahodaj marked this pull request as ready for review December 18, 2025 18:27
@mbien mbien added the debugger label Dec 18, 2025
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debugger Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants