Expose Fix Imports command to LSP Clients #9062
Open
+530
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahodaj
reviewed
Dec 15, 2025
Contributor
lahodaj
left a comment
lahodaj
left a comment
There was a problem hiding this comment.
Overall seems reasonable to me, with some suggestions for small cleanups inline.
| /** Creates a new instance of JavaFixAllImports */ | ||
| private JavaFixAllImports() { | ||
| } | ||
|
|
| */ | ||
| public abstract class CodeActionsProvider { | ||
|
|
||
| public static final String FIX_IMPORTS_KIND = "source.fixImports"; |
Contributor
There was a problem hiding this comment.
I suspect this should be moved to java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/FixImportsCodeAction.java? (I think that's consistent with what is being done for other ordinary implementations of CodeActionsProviders.
| import org.eclipse.lsp4j.CodeActionKind; | ||
| import org.eclipse.lsp4j.CodeActionParams; | ||
| import org.eclipse.lsp4j.TextEdit; | ||
| import org.eclipse.lsp4j.WorkspaceEdit; |
Contributor
There was a problem hiding this comment.
The changes in this file do not seem to be necessary - these can be removed.
shivam71
force-pushed
the
cmd_fix_imports
branch
from
fe4b915 to
322b794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Imports Code action for LSP Client
Fix Imports...as a source code action to add all missing imports in one command.Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)