Replace "synchronized" blocks in AbstractSession with ReentrantLock#858
Merged
tomaswolf merged 1 commit intoapache:masterfrom Jan 2, 2026
Merged
Replace "synchronized" blocks in AbstractSession with ReentrantLock#858tomaswolf merged 1 commit intoapache:masterfrom
tomaswolf merged 1 commit intoapache:masterfrom
Conversation
synchronized blocks pin the virtual thread under JDK21+ to physical thread. It is better to avoid such pinning in I/O bound operations so VirtualThread planner can do its job
b1c47cd to
1e5d9bc
Compare
Member
|
There are a lot more synchronized blocks and methods in Apache MINA sshd. I'm fine with replacing these two; I would object to replacing all uses of If thread pinning is a problem, I think you could migrate to Java >= 24, which should have JEP-491 implemented: using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronized blocks pin the virtual thread under JDK21+ to physical thread. It is better to avoid such pinning in I/O bound operations so VirtualThread planner can do its job