[RSPEC-S1068] Remove unused private fields#2317
[RSPEC-S1068] Remove unused private fields#2317Pankraz76 wants to merge 3 commits intoapache:masterfrom
unused private fields#2317Conversation
|
|
||
| private static final long ONE_HOUR = 60 * ONE_MINUTE; | ||
|
|
||
| private static final long ONE_DAY = 24 * ONE_HOUR; |
There was a problem hiding this comment.
this might be API but seems unused
There was a problem hiding this comment.
Want to investigate, what its actually used for.
Pankraz76
force-pushed
the
RemoveUnusedPrivateFields
branch
from
f1dbef5 to
1c1a395
Compare
|
|
||
| private static final long ONE_MINUTE = 60 * ONE_SECOND; | ||
|
|
||
| private static final long ONE_HOUR = 60 * ONE_MINUTE; |
There was a problem hiding this comment.
- Private field 'ONE_HOUR' is never used openrewrite/rewrite-static-analysis#554
assuming circle issue as last block item was found.ONE_DAY
|
SUCCESS 
|
|
kindly request some feedback. |
|
|
||
| class MavenITmng6401ProxyPortInterpolationTest extends AbstractMavenIntegrationTestCase { | ||
|
|
||
| private Proxy proxy; |
There was a problem hiding this comment.
These might be used in a weird way by reflection in the integration tests. I'm not sure in this case, but Maven does have a lot of private things that look unused but really are used like that.
There was a problem hiding this comment.
yes then its nice to have good TC to challenge or suppress.
| */ | ||
| public class MyMojo extends AbstractMojo { | ||
|
|
||
| /** |
There was a problem hiding this comment.
I think the comment shows why and how this is used here. Please check this sort of thing before sending PRs from automated tools.
There was a problem hiding this comment.
yes im sorry.
order 100% test coverage or deletion.
There was a problem hiding this comment.
yes its unused. Details does not help me. Im unaware.
From technical POV its seems obsolet.
If CI happy ship or test / use as its only test stage.
| * Not used, just an offset to place reactorProjects in the middle. | ||
| * @parameter default-value="${project.build.directory}" | ||
| */ | ||
| private String outputDirectory2; |
There was a problem hiding this comment.
seems c&p leftover.
The matcher returned by that method combines the effects of all includes and excludes.
When using the Maven syntax, escape the special characters [ ] { } \ before to delegate to the glob syntax.
Optimization: omit excludes that are unnecessary because they will never match a file accepted by includes.
This is especially useful when the default excludes are added, because there is a lot of them.
---------
Co-authored-by: VIP <8830888+Pankraz76@users.noreply.github.com>
Also, add newly introduced methods to `FastTerminal`. JLine 3.30.0 release notes: https://github.com/jline/jline3/releases/tag/jline-3.30.0 --- https://issues.apache.org/jira/browse/MNG-8726
|
wip reopen |
4 participants
[RSPEC-S1068] Remove
unusedprivate fieldsenabler to:
rewrite-maven-plugin: Introduce OpenRewrite by Moderne #2322