[MSHADE-156] Allow non relocating string literals #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Seems this also addresses MSHADE-153. |
1 task
|
Resolve #518 |
1 similar comment
|
Resolve #518 |
Contributor
|
can you merge with master? |
elharo
changed the title
elharo
requested changes
Sep 25, 2025
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
This feels like it needs some additions to the docs somewhere. Adding a property without documenting it is unlikely to help folks.
| * @param entityName entity name to be mapped | ||
| * @param mapPaths map "slashy" names like paths or internal Java class names, e.g. {@code com/acme/Foo}? | ||
| * @param mapPackages map "dotty" names like qualified Java class or package names, e.g. {@code com.acme.Foo}? | ||
| * @param mapLiterals map string literals, e.g. {@code "com.acme.Foo"}? |
|
|
||
| @Test | ||
| public void testShaderWithoutStringLiterals() throws Exception { | ||
| Shader s = newShader(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Jira issue: MSHADE-156
Add the option to skip relocating string literals. Currently this is not possible and the only available solution is to create a "fake" relocation pattern to prevent such behavior, example.
This change adds a new property
skipStringLiteralwhich still relocates the prefix instances but not the string literals.Testing
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MSHADE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MSHADE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.