Skip to content

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented Mar 17, 2022

Revive pre 69aeda6 commit DF DependencyCollector, and keep the BF one. as well.

High level changes:

  • for now, for simplicity sake, copied the classes (changes or deleted) to bf and df subpackage.
  • DefaultDependencyCollector is now just an indirector, that delegates based on session config
  • the aether.collector.impl introduced config property (names: "df", "bf") can be used to select collector implementation
  • default is as pre BF commit, "df"

https://issues.apache.org/jira/browse/MRESOLVER-248

@cstamas cstamas requested a review from michael-o March 17, 2022 13:28
@cstamas cstamas self-assigned this Mar 17, 2022
@cstamas
Copy link
Member Author

cstamas commented Mar 17, 2022

@caiwei-ebay ping here

@kwin
Copy link
Member

kwin commented Mar 17, 2022

I think this deserves a JIRA ticket with some reasoning why this should be reintroduced. Also the new config property should be documented at https://github.com/apache/maven-resolver/blob/master/src/site/markdown/configuration.md.

@cstamas
Copy link
Member Author

cstamas commented Mar 18, 2022

MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso… #158

Sure, this PR is merely to simplify testing/comparison phase, for explanation of "why" see here (and above for perf test results): #158 (comment)

In short: My (incomplete) perf testing showed slight but measurable degradation of performance, so the coexistence is here only to simplify testing. Once we decide what should happen (keep this, keep that, or keep both) a complete overhaul, doco and other update will happen. Still, right now am leaning to keep both, at least until we see related changes done (BFS + skipper + parallel POM download)...

@cstamas cstamas changed the title DependencyCollector: DF vs BF coexists [MRESOLVER-248] DependencyCollector: let DF vs BF implementations coexists Mar 18, 2022
@cstamas
Copy link
Member Author

cstamas commented Apr 4, 2022

Superseded by #161

@cstamas cstamas closed this Apr 4, 2022
@cstamas cstamas deleted the bf-df-coexitsts branch April 4, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants