Conversation
|
Thanks |
|
you have closed this without any comment i remember. what is going on here? |
gnodet
left a comment
There was a problem hiding this comment.
We use spotless to reformat code or fix things. Afaik, we don't have any rule that would not automatically be fixed by spotless. We already have a checkstyle rule to forbid wildcard imports, so not sure what the benefit would be with this PR.
I'd be happy if we could have an automatic transformation of wildcard imports to individual imports, but unless that's possible, I'm against duplicating the checks for no added value.
|
Nice, yes — then it’s just the second layer. Maybe automation will become a thing later on. For now, it’s currently not fixable, that’s correct. So in the end, it wouldn’t do any harm, as it’s similar to the existing solution — assuming this might increase coverage. |
is the new feature anything good for maven?
related to:
removeWildcardImports()diffplug/spotless#2526