Skip to content

Implement missing tests and cleanup TODOs in DependencyVisitorTest #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanjana2505006 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement missing tests and cleanup TODOs in DependencyVisitorTest #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,9 @@ void testVisitSource() {
void testVisitOuterClass() {
// class a.b.c
// {
// class ...
// {
// }
// class ...
// {
// }
// }
visitor.visitOuterClass("a/b/c", null, null);

Expand All @@ -163,12 +163,12 @@ void testVisitOuterClass() {
void testVisitOuterClassInMethod() {
// class a.b.c
// {
// x.y.z x(p.q.r p)
// {
// class ...
// {
// }
// }
// x.y.z x(p.q.r p)
// {
// class ...
// {
// }
// }
// }
visitor.visitOuterClass("a/b/c", "x", "(Lp/q/r;)Lx/y/z;");

Expand Down Expand Up @@ -204,10 +204,8 @@ void testVisitAttribute() {

@Test
void testVisitInnerClass() {
// TODO: ensure innerName is correct

// class a.b.c { class x.y.z { } }
visitor.visitInnerClass("x/y/z", "a/b/c", "z", 0);
// class a.b.c { class x { } }
visitor.visitInnerClass("a/b/c$x", "a/b/c", "x", 0);

assertThat(resultCollector.getDependencies()).isEmpty();
}
Expand All @@ -230,10 +228,13 @@ void testVisitField() {
assertThat(resultCollector.getDependencies()).containsOnly("a.b.c");
}

// TODO: determine actual use of default values
// void testVisitFieldWithValue()
// {
// }
@Test
void testVisitFieldWithValue() {
// a.b.c a = x.y.z.class
assertVisitor(visitor.visitField(0, "a", "La/b/c;", null, Type.getType("Lx/y/z;")));

assertThat(resultCollector.getDependencies()).containsOnly("a.b.c", "x.y.z");
}

@Test
void testVisitFieldArray() {
Expand Down