Skip to content

Conversation

@HarshMehta112
Copy link

@HarshMehta112 HarshMehta112 commented Nov 29, 2025

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Fixes : #951

This PR updates ArchetypeSelectorUtils to use String.contains(...) instead of deprecated StringUtils.contains methods. This removes warnings, reduces dependency usage, and simplifies the filter-parsing logic. No functional changes.

…orUtils

Signed-off-by: Harsh Mehta <harshmehta010102@gmail.com>

private static String extractGroupIdFromFilter(String filter) {
return StringUtils.contains(filter, ':') ? StringUtils.substringBefore(filter, ":") : null;
return filter.contains(":") ? StringUtils.substringBefore(filter, ":") : null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also 2nd call in this line? StringUtils.substringBefore

@slachiewicz slachiewicz marked this pull request as draft December 31, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation warnings for contains

2 participants