[ARCHETYPE-638] maven-archetype pom.xml should add request encoding #129
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
reviewed
Mar 19, 2023
archetype-common/src/main/java/org/apache/maven/archetype/creator/FilesetArchetypeCreator.java
Outdated
Show resolved
Hide resolved
qxo
force-pushed
the
fix/archetypePomBuildEncoding
branch
from
c55cca9 to
ceb3745
Compare
michael-o
reviewed
Mar 20, 2023
archetype-common/src/main/java/org/apache/maven/archetype/creator/FilesetArchetypeCreator.java
Outdated
Show resolved
Hide resolved
qxo
force-pushed
the
fix/archetypePomBuildEncoding
branch
from
ceb3745 to
941ab44
Compare
michael-o
reviewed
Mar 20, 2023
Member
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
Why is this not part of the configurationProperties?
Author
I have no idea about that. |
Member
Try to evaluate that... |
…oding This commit remove below warning: [WARNING] Using platform encoding (GBK actually) to copy filtered resources, i.e. build is platform dependent!
qxo
force-pushed
the
fix/archetypePomBuildEncoding
branch
from
941ab44 to
ec356cb
Compare
elharo
changed the title
|
Resolve #869 |
1 similar comment
|
Resolve #869 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit remove below warning:
[WARNING] Using platform encoding (GBK actually) to copy filtered resources, i.e. build is platform dependent!