Fix test bug in TestTopDocsCollector and TestTopFieldCollector#15495
Merged
jainankitk merged 1 commit intoapache:mainfrom Apr 10, 2026
Merged
Fix test bug in TestTopDocsCollector and TestTopFieldCollector#15495jainankitk merged 1 commit intoapache:mainfrom
jainankitk merged 1 commit intoapache:mainfrom
Conversation
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
dweiss
added
the
skip-changelog
Contributor
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
Contributor
Author
|
Hi @jainankitk, could you help to review this PR? Thanks! |
Contributor
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
jainankitk
approved these changes
Apr 10, 2026
Contributor
jainankitk
left a comment
jainankitk
left a comment
There was a problem hiding this comment.
Changes look valid and make the test intent clearer!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the following bugs in TestTopDocsCollector and TestTopFieldCollector:
leafCollector.collect(4), the documents count in this segment should be greater than 4.The test result won't be changed, but this PR makes the test cases more clear.