Skip to content

Fix: Remote Denial of Service (Infinite Loop) in TelnetAppender #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OxBat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Remote Denial of Service (Infinite Loop) in TelnetAppender #583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/cpp/telnetappender.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,8 @@ void TelnetAppender::write(ByteBuffer& buf)

void TelnetAppender::writeStatus(const SocketPtr& socket, const LogString& msg, Pool& p)
{
size_t bytesSize = msg.size() * 2;
// Ensure minimum buffer size to prevent infinite loop in encoder with short messages
size_t bytesSize = (msg.size() * 2 > 1024) ? msg.size() * 2 : 1024;
char* bytes = p.pstralloc(bytesSize);

LogString::const_iterator msgIter(msg.begin());
Expand All @@ -232,7 +233,8 @@ void TelnetAppender::append(const spi::LoggingEventPtr& event, Pool& p)
else
msg = event->getRenderedMessage();
msg.append(LOG4CXX_STR("\r\n"));
size_t bytesSize = msg.size() * 2;
// Ensure minimum buffer size to prevent infinite loop in encoder with short messages
size_t bytesSize = (msg.size() * 2 > 1024) ? msg.size() * 2 : 1024;
char* bytes = p.pstralloc(bytesSize);

LogString::const_iterator msgIter(msg.begin());
Expand Down
Loading