KNOX-3202: Oracle DB support for TokeStateService, Refactored JDBCUti… #1134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ls into DataSourceFactory
KNOX-3202 - Add support for Oracle DB as a Token State backend
What changes were proposed in this pull request?
com.oracle.database.jdbc.ojdbc11dependency withprovidedscope.JDBCUtilsinto factory pattern so every class has its clear responsibilities.How was this patch tested?
mvn clear verifyBelow manual tests:
I started up Knox with a specific database type, created a new token, queried that token on the token management UI and also verified in the DB.
Tested oracle, derby, mysql, postgres and mariadb locally with docker images
Oracle:
gvenzl/oracle-freejdbc:oracle:thin:localhost:1521/FREEPDB1MariaDB:
mariadb:11jdbc:mariadb://127.0.0.1:3306/testdb?user=testuser&password=testpassMySQL:
mysql:8.4PostgreSQL:
postgres:16Oracle: