KAFKA-20397 Avoid blocking on fetchBuffer when metadata error is pending#21991
Open
nileshkumar3 wants to merge 1 commit intoapache:trunkfrom
Open
KAFKA-20397 Avoid blocking on fetchBuffer when metadata error is pending#21991nileshkumar3 wants to merge 1 commit intoapache:trunkfrom
nileshkumar3 wants to merge 1 commit intoapache:trunkfrom
Conversation
github-actions
bot
added
triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a metadata error (e.g. TopicAuthorizationException) is discovered by the background thread
and set on the inflight AsyncPollEvent between checkInflightPoll() and fetchBuffer.awaitWakeup()
in pollForFetches(), the consumer blocks for the full poll timeout before surfacing the error.
This adds a check in pollForFetches() to skip the blocking wait when the inflight poll event
already has a metadata error, allowing the error to be surfaced promptly on the next iteration
of the poll loop via checkInflightPoll().
Reviewers - @lianetm @AndrewJSchofield @kirktrue