KAFKA-20398: Fix memory leak by removing StreamsThreadMetricsDelegatingReporter from metrics registry on thread shutdown#21973
Merged
bbejeck merged 1 commit intoapache:trunkfrom Apr 7, 2026
Conversation
…ngReporter from metrics registry on thread shutdown Signed-off-by: Szabolcs Stremler <stremler.sz@gmail.com>
mjsax
approved these changes
Apr 7, 2026
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Thanks for the quick fix. LGTM.
Member
|
Merged #21971 into trunk |
bbejeck
pushed a commit
that referenced
this pull request
Apr 7, 2026
…ngReporter from metrics registry on thread shutdown (#21973) When a stream thread in Kafka Streams crashes, `StreamsUncaughtExceptionHandler` can be configured to replace the crashed thread with a new one. Each time a new stream thread is created, it adds a new `StreamsThreadMetricsDelegatingReporter` to it. However, when the old thread shuts down, its reporter is never removed from the registry implying "unbounded" memory growth. This bug was introduced via #17021 This PR ensures that the existing `StreamsThreadMetricsDelegatingReporter` is removed when a thread is shutting down. Reviewers: Matthias J. Sax <matthias@confluent.io>, Bill Bejeck <bbejeck@apache.org> Signed-off-by: Szabolcs Stremler <stremler.sz@gmail.com>
Member
|
cherry-picked to 4.3 |
Member
|
@sstremler I tried cherry-picking to 4.2 but there are some conflcts, can you do a separate PR for 4.2? |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a stream thread in Kafka Streams crashes,
StreamsUncaughtExceptionHandlercan be configured to replace thecrashed thread with a new one. Each time a new stream thread is created,
it adds a new
StreamsThreadMetricsDelegatingReporterto it. However,when the old thread shuts down, its reporter is never removed from the
registry implying "unbounded" memory growth.
This bug was introduced via #17021
This PR ensures that the existing
StreamsThreadMetricsDelegatingReporteris removed when a thread isshutting down.
Reviewers: Matthias J. Sax matthias@confluent.io, Bill Bejeck
bbejeck@apache.org