KAFKA-19483 : storage : Fix resource leak, cleanup#21964
Open
muralibasani wants to merge 1 commit intoapache:trunkfrom
Open
KAFKA-19483 : storage : Fix resource leak, cleanup#21964muralibasani wants to merge 1 commit intoapache:trunkfrom
muralibasani wants to merge 1 commit intoapache:trunkfrom
Conversation
github-actions
bot
added
triage
muralibasani
changed the title
Contributor
Author
|
@Shekharrajak would you like to take a look ? |
Shekharrajak
approved these changes
Apr 6, 2026
Shekharrajak
left a comment
Shekharrajak
left a comment
There was a problem hiding this comment.
The test testDeleteInvalidIndexFilesOnInit uses the same logDir for the secondCache as the primary cache field. Since both caches share the same directory, the secondCache.close() in the try-with-resources will shut down the second cache's cleaner, but if it also affects files that the primary cache relies on, there could be interference. Looking at the test, it creates separate rlsMetadata with baseOffset + 100, so the index files should be distinct. This looks safe.
|
|
||
| // Wait for all scheduled cleanup tasks to complete so the cleaner thread is idle before @AfterEach | ||
| // shuts it down. This prevents a race between an in-flight task and scheduler shutdown. | ||
| TestUtils.waitForCondition(() -> cache.expiredIdxPendingForDeletion() == 0, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/KAFKA-19483
Fixes below issues.