JAMES-4186 [REFACTOR] EmaiQueryOptimizer interface to wrap email query view logic in JMAP EmailQueryMethod#2963
Open
Arsnael wants to merge 3 commits intoapache:masterfrom
Open
JAMES-4186 [REFACTOR] EmaiQueryOptimizer interface to wrap email query view logic in JMAP EmailQueryMethod#2963Arsnael wants to merge 3 commits intoapache:masterfrom
Arsnael wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
Do we have a JIRA ticket for this? Please open it. |
chibenwa
reviewed
Mar 5, 2026
...r/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/EmailQueryMethod.scala
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Mar 5, 2026
Contributor
chibenwa
left a comment
chibenwa
left a comment
There was a problem hiding this comment.
On the principle, YES !
…y view logic in JMAP EmailQueryMethod
…il query view logic in JMAP EmailQueryMethod
Arsnael
force-pushed
the
email-query-optimizer
branch
from
12e9543 to
24342c1
Compare
Arsnael
changed the title
...rotocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/EmailQueryOptimizer.scala
Outdated
Show resolved
Hide resolved
…il query view logic in JMAP EmailQueryMethod
quantranhong1999
approved these changes
Mar 6, 2026
chibenwa
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to be able to add custom optimizers for email query
I know we said initially the predicate would be EmailQueryRequest => Option[SFlux[MessageId]]
But I don't think that re-extracting and re-verifying the search query, limit and position from the request for each optimizer is optimal. Also we need the session.