[ENHANCEMENT] OIDC SASL code refactoring #2888
Conversation
|
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (check-style) on project protocols-imap: You have 1 Checkstyle violation. -> [Help 1] will check... |
|
Please help push fixes on this... (Currently in vacation for 2 weeks) |
|
Ok earlier I was struggling because I forgot the 3.8 version is running on jdk 11 (my bad) However now I compiles fine. mailetdocs-maven-plugin does tests well locally too. I'm not too sure what's going on with the CI? Will dig a bit more but... or can we just remove that mailetdocs-maven-plugin thing for the 3.8.x branch? |
Arsnael
force-pushed
the
3.8.x-bp-sasl
branch
from
cea5704 to
bd4ddf2
Compare
|
Ok I think when applying the docker fix it made an other change I didn't see first in jenkinsfile (an extra clean in mvn for tests). I reverted it. It seems now it's building. Will monitor |
- Mutualize code for choosing how code shall be validated between IMAP and SMTP - Turn OidcJwtTokenVerifier as a class - Have SASL configuration as a member in order to limit count of arguments
Docker v29 introduces a breaking change in the client API requirement: https://docs.docker.com/engine/release-notes/29/#breaking-changes This introduces an issue with testcontainers cf testcontainers/testcontainers-java#11212 CI builds failed because of this: `client version 1.32 is too old. Minimum supported API version is 1.44, please upgrade your client to a newer version`. In the time waiting for a new release of testcontainers, we can apply the recommended workaround to enforce client version to required v1.44.
cf opencontainers/runc#4971 runc update recently has resulted in the default permissions on docker tmpfs being 0755 rather than the expected 1777, which makes OpenSearch tests failed to acquire the lock on file system.
v0.105 is not available anymore
Arsnael
force-pushed
the
3.8.x-bp-sasl
branch
from
0a77a27 to
2db1cdd
Compare
3 participants
No description provided.