JCR-5226: Base64 decoder does not handle lack of padding correctly #332
+105
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly - failing test case
…tly - minimal change to handle missing padding (instead of returning garbage)
kwin
approved these changes
Feb 4, 2026
| // handle missing padding gracefully, inspired by | ||
| // https://datatracker.ietf.org/doc/html/rfc7515#appendix-C | ||
| if (posChunk == 1) { | ||
| throw new IllegalArgumentException("specified data is not base64 encoded"); |
Contributor
Author
There was a problem hiding this comment.
TDB
The weird thing is that in case of IAEs, the (existing) code does return the input string (who knows why)
Contributor
Author
|
... while we're at it, we may want to improve the Javadoc. |
reschke
changed the title
Contributor
Author
|
There are more bugs (decoding "a=b" etc); but these fall into the category "garbage in, garbage out", not "correct input, garbage out). |
reschke
changed the title
|
kwin
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.