Skip to content

Pipe: Improved the total performance by disable some useless logic #17448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JackieTien97 merged 1 commit into from
Apr 8, 2026

Pipe: Improved the total performance by disable some useless logic

a5432db
Select commit
Loading
Failed to load commit list.
Merged

Pipe: Improved the total performance by disable some useless logic #17448

Pipe: Improved the total performance by disable some useless logic
a5432db
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 8, 2026 in 3m 7s

Quality Gate passed

Issues
31 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 249 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/readchunk/ReadChunkAlignedSeriesCompactionExecutor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ1W0YMKf6I9cMhs&open=AZ1shZ1W0YMKf6I9cMhs&pullRequest=17448

Check warning on line 351 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/performer/impl/ReadChunkCompactionPerformer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "schema" which hides the field declared at line 75. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ2w0YMKf6I9cMh5&open=AZ1shZ2w0YMKf6I9cMh5&pullRequest=17448

Check warning on line 327 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/performer/impl/ReadChunkCompactionPerformer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ2w0YMKf6I9cMh3&open=AZ1shZ2w0YMKf6I9cMh3&pullRequest=17448

Check warning on line 196 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/externalservice/ExternalServiceManagementService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Throwable. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ5z0YMKf6I9cMiF&open=AZ1shZ5z0YMKf6I9cMiF&pullRequest=17448

Check warning on line 243 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/protocol/pipeconsensus/PipeConsensusAsyncSink.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 115). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ6J0YMKf6I9cMiG&open=AZ1shZ6J0YMKf6I9cMiG&pullRequest=17448

Check failure on line 148 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/readchunk/ReadChunkAlignedSeriesCompactionExecutor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 26 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ1W0YMKf6I9cMhu&open=AZ1shZ1W0YMKf6I9cMhu&pullRequest=17448

Check warning on line 230 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/readchunk/ReadChunkAlignedSeriesCompactionExecutor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ1W0YMKf6I9cMht&open=AZ1shZ1W0YMKf6I9cMht&pullRequest=17448

Check warning on line 2005 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/AlignedTVList.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 138 to 64, Complexity from 41 to 14, Nesting Level from 5 to 2, Number of Variables from 21 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ8f0YMKf6I9cMiH&open=AZ1shZ8f0YMKf6I9cMiH&pullRequest=17448

Check warning on line 125 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/model/ModelInformation.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused private "buildOutputDataTypeForBuiltInModel" method. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ0J0YMKf6I9cMhp&open=AZ1shZ0J0YMKf6I9cMhp&pullRequest=17448

Check warning on line 419 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/MultiTsFileDeviceIterator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Local variable name 'iMeasurementSchema' must match pattern '^[a-z]([a-z0-9][a-zA-Z0-9]*)?$'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ2H0YMKf6I9cMh1&open=AZ1shZ2H0YMKf6I9cMh1&pullRequest=17448

Check warning on line 213 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AbstractWritableMemChunk.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 108). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ380YMKf6I9cMiA&open=AZ1shZ380YMKf6I9cMiA&pullRequest=17448

Check warning on line 227 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AbstractWritableMemChunk.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'needCloneTimesAndIndicesInWorkingTVList' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ380YMKf6I9cMiC&open=AZ1shZ380YMKf6I9cMiC&pullRequest=17448

Check warning on line 672 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/CompactionUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ2b0YMKf6I9cMh2&open=AZ1shZ2b0YMKf6I9cMh2&pullRequest=17448

Check failure on line 203 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/readchunk/ReadChunkAlignedSeriesCompactionExecutor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 28 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ1W0YMKf6I9cMhv&open=AZ1shZ1W0YMKf6I9cMhv&pullRequest=17448

Check failure on line 713 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/SeriesScanUtil.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ5Z0YMKf6I9cMiE&open=AZ1shZ5Z0YMKf6I9cMiE&pullRequest=17448

Check warning on line 392 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/WritableMemChunk.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ3P0YMKf6I9cMh6&open=AZ1shZ3P0YMKf6I9cMh6&pullRequest=17448

Check failure on line 324 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/MultiTsFileDeviceIterator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 23 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ2H0YMKf6I9cMhz&open=AZ1shZ2H0YMKf6I9cMhz&pullRequest=17448

Check warning on line 364 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/performer/impl/ReadChunkCompactionPerformer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ2w0YMKf6I9cMh4&open=AZ1shZ2w0YMKf6I9cMh4&pullRequest=17448

Check warning on line 628 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AlignedWritableMemChunk.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "dataTypes" which hides the field declared at line 69. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ3m0YMKf6I9cMh8&open=AZ1shZ3m0YMKf6I9cMh8&pullRequest=17448

Check warning on line 572 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AlignedWritableMemChunk.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Distance between variable 'time' declaration and its first usage is 7, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ3m0YMKf6I9cMh_&open=AZ1shZ3m0YMKf6I9cMh_&pullRequest=17448

Check warning on line 39 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/externalservice/ServiceInfo.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "transient" modifier from this field. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ0j0YMKf6I9cMhr&open=AZ1shZ0j0YMKf6I9cMhr&pullRequest=17448

Check failure on line 506 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/MultiTsFileDeviceIterator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 28 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ2H0YMKf6I9cMh0&open=AZ1shZ2H0YMKf6I9cMh0&pullRequest=17448

Check warning on line 385 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/WritableMemChunk.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 78 to 64, Complexity from 19 to 14, Nesting Level from 3 to 2, Number of Variables from 12 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ3P0YMKf6I9cMh7&open=AZ1shZ3P0YMKf6I9cMh7&pullRequest=17448

Check warning on line 345 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/MultiTsFileDeviceIterator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ2H0YMKf6I9cMhx&open=AZ1shZ2H0YMKf6I9cMhx&pullRequest=17448

Check warning on line 214 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AbstractWritableMemChunk.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 108). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ1shZ380YMKf6I9cMiB&open=AZ1shZ380YMKf6I9cMiB&pullRequest=17448
View more details on SonarQubeCloud