Skip to content

Pipe: check file receiver write path#17442

Merged
jt2594838 merged 2 commits intoapache:masterfrom
luoluoyuyu:fix/pipe-receiver-path-traversal
Apr 9, 2026
Merged

Pipe: check file receiver write path#17442
jt2594838 merged 2 commits intoapache:masterfrom
luoluoyuyu:fix/pipe-receiver-path-traversal

Conversation

@luoluoyuyu
Copy link
Copy Markdown
Member

@luoluoyuyu luoluoyuyu commented Apr 8, 2026


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Normalize and validate incoming file paths against the receiver base directory before creating write targets, preventing directory-escape writes and strengthening receiver-side file safety.

Made-with: Cursor
@jt2594838 jt2594838 changed the title Pipe: prevent path traversal in file receiver write path Pipe: check file receiver write path Apr 8, 2026
Copy link
Copy Markdown
Contributor

@jt2594838 jt2594838 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May add a test

@jt2594838 jt2594838 merged commit 57fe1c9 into apache:master Apr 9, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants