refactor: Eliminate global state in remoting config and improve architecture clarity

[rookiewwj]

Summary

This PR refactors the configuration architecture in the remoting layer by removing the problematic SeataConfig struct and eliminating global state, resulting in cleaner separation of concerns and improved testability.

Motivation

The previous SeataConfig design had several issues:

1. Mixed responsibilities: Combined configurations from different layers (remoting, discovery, and getty) into a single struct
2. Redundant fields: ServiceVgroupMapping and ServiceGrouplist were copied from discovery config but never actually used in remoting
3. Global state: Configuration was stored in a global variable (seataConfig), making the code harder to test and maintain
4. Unclear data flow: Dependencies between modules were obscured by global variable access

Changes

Removed

• SeataConfig struct from config.go
• Global variable seataConfig and associated InitConfig() / GetSeataConfig() functions
• Unnecessary configuration copying in client.go
• Tests for removed functionality

Added

• New ClientIdentity struct in identity.go to represent client identity information (ApplicationID and TxServiceGroup)

Modified

• InitGetty() signature: now accepts *ClientIdentity instead of *SeataConfig
• initSessionManager(): updated to receive and store *ClientIdentity as an instance field
• SessionManager:
  • Added clientIdentity field to eliminate global config access
  • Now uses g.gettyConf.LoadBalanceType directly instead of accessing global state
  • Uses g.clientIdentity.TxServiceGroup for service lookup
• listener.go: accesses sessionManager.clientIdentity instead of global GetSeataConfig()

Benefits

• ✅ Better separation of concerns: Each layer manages its own configuration
• ✅ No global state: All dependencies are passed explicitly, improving testability
• ✅ Cleaner data flow: Configuration flows directly from client initialization to the components that need it
• ✅ Reduced coupling: Modules no longer depend on a centralized global configuration
• ✅ Code size reduction: Net reduction of 62 lines of code

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.66%. Comparing base (55e99b4) to head (5e02003).

Files with missing lines	Patch %	Lines
pkg/remoting/getty/session_manager.go	0.00%	4 Missing ⚠️
pkg/remoting/getty/listener.go	0.00%	3 Missing ⚠️
pkg/client/client.go	0.00%	2 Missing ⚠️
pkg/remoting/getty/getty_init.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1031   +/-   ##
=======================================
  Coverage   57.66%   57.66%           
=======================================
  Files         267      267           
  Lines       17665    17658    -7     
=======================================
- Hits        10187    10183    -4     
+ Misses       6650     6647    -3     
  Partials      828      828           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Code-Fight]

I think we should keep a naming style similar to remoteConfig.SeataConfig, rather than using getty.ClientIdentity.
Getty is not equivalent to remote — getty is just one implementation of remote.
It can be understood as an abstraction, but the name itself could be changed to something more elegant.

[rookiewwj]

ok, i will change the name style similar to remoteConfig.SeataConfig

[Code-Fight]

You removed the old unit test code, but did not add additional tests to cover the newly added code. As a result, the current test coverage has decreased and more unit tests need to be added.

[rookiewwj]

fine, i will add more test to cover the newly code

[thunguo]

Plz resolve the conflicts and re-run the integrate-test CI.

[thunguo]

LGTM