chore: remove unused pgsql configuration from Helm chart values#364
Merged
klesh merged 1 commit intoapache:mainfrom Feb 26, 2026
Merged
chore: remove unused pgsql configuration from Helm chart values#364klesh merged 1 commit intoapache:mainfrom
klesh merged 1 commit intoapache:mainfrom
Conversation
### Summary This PR removes the commented `pgsql` configuration block from the Helm chart `values.yaml`. ### Motivation The chart currently exposes commented PostgreSQL configuration that appears to suggest PostgreSQL is supported, but: - The chart only implements MySQL configuration paths. - The `pgsql` values are not wired into templates. - Setting `option.database=pgsql` does not produce a working deployment. This creates confusion for users and leads to time spent attempting to configure an unsupported path. ### Change - Removes the commented `pgsql` configuration block from values.yaml. - Leaves MySQL as the clearly supported database option. ### Benefit - Reduces ambiguity around supported database backends. - Prevents users from attempting a non-functional configuration. - Improves chart clarity and maintainability. If/when PostgreSQL support becomes fully implemented, the configuration can be reintroduced with complete wiring and documentation. Happy to help reintroduce when full support exists.
|
+1 |
klesh
approved these changes
Feb 26, 2026
Contributor
klesh
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the commented
pgsqlconfiguration block from the Helm chartvalues.yaml.Motivation
The chart currently exposes commented PostgreSQL configuration that appears to suggest PostgreSQL is supported, but:
pgsqlvalues are not wired into templates.option.database=pgsqldoes not produce a working deployment.This creates confusion for users and leads to time spent attempting to configure an unsupported path.
Change
pgsqlconfiguration block from values.yaml.Benefit
If/when PostgreSQL support becomes fully implemented, the configuration can be reintroduced with complete wiring and documentation.
Happy to help reintroduce when full support exists.