Ignite 27473

modules/core/src/main/java/org/apache/ignite/internal/IgniteNodeAttributes.java

@@ -199,6 +199,9 @@ public final class IgniteNodeAttributes {
     /** Data center ID. */
     public static final String ATTR_DATA_CENTER_ID = ATTR_PREFIX + ".datacenter.id";
 
+    /** WAL mode configuration. */
+    public static final String ATTR_WAL_MODE = ATTR_PREFIX + ".wal.mode";
+
     /**
      * Enforces singleton.
      */

modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java

@@ -58,6 +58,7 @@
 import org.apache.ignite.configuration.DataStorageConfiguration;
 import org.apache.ignite.configuration.DefaultCommunicationFailureResolver;
 import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.configuration.WALMode;
 import org.apache.ignite.events.DiscoveryEvent;
 import org.apache.ignite.events.Event;
 import org.apache.ignite.events.EventType;
@@ -176,6 +177,7 @@
 import static org.apache.ignite.internal.IgniteNodeAttributes.ATTR_SECURITY_COMPATIBILITY_MODE;
 import static org.apache.ignite.internal.IgniteNodeAttributes.ATTR_SHUTDOWN_POLICY;
 import static org.apache.ignite.internal.IgniteNodeAttributes.ATTR_USER_NAME;
+import static org.apache.ignite.internal.IgniteNodeAttributes.ATTR_WAL_MODE;
 import static org.apache.ignite.internal.IgniteVersionUtils.VER;
 import static org.apache.ignite.internal.events.DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT;
 import static org.apache.ignite.internal.processors.metric.impl.MetricUtils.metricName;
@@ -484,6 +486,11 @@ private void updateClientNodes(UUID leftNodeId) {
         ctx.addNodeAttribute(ATTR_OFFHEAP_SIZE, requiredOffheap());
         ctx.addNodeAttribute(ATTR_DATA_REGIONS_OFFHEAP_SIZE, configuredOffheap());
 
+        DataStorageConfiguration dsCfg = ctx.config().getDataStorageConfiguration();
+
+        if (CU.isPersistenceEnabled(dsCfg))
+            ctx.addNodeAttribute(ATTR_WAL_MODE, dsCfg.getWalMode().ordinal());
+
         DiscoverySpi spi = getSpi();
 
         discoOrdered = discoOrdered();
@@ -1279,6 +1286,9 @@ private void checkAttributes(Iterable<ClusterNode> nodes) throws IgniteCheckedEx
 
         Boolean locSecurityCompatibilityEnabled = locNode.attribute(ATTR_SECURITY_COMPATIBILITY_MODE);
 
+        WALMode locWalMode = locNode.attribute(ATTR_WAL_MODE) == null ? null :
+            WALMode.fromOrdinal(locNode.attribute(ATTR_WAL_MODE));
+
         for (ClusterNode n : nodes) {
             int rmtJvmMajVer = nodeJavaMajorVersion(n);
 
@@ -1383,6 +1393,16 @@ private void checkAttributes(Iterable<ClusterNode> nodes) throws IgniteCheckedEx
                         ", locNodeId=" + locNode.id() + ", rmtNode=" + U.toShortString(n) + "]");
                 }
             }
+
+            WALMode rmtWalMode = n.attribute(ATTR_WAL_MODE) == null ? null :
+                WALMode.fromOrdinal(n.attribute(ATTR_WAL_MODE));
+
+            if (!Objects.equals(locWalMode, rmtWalMode)) {
+                throw new IgniteCheckedException("Remote node has WAL mode different from local " +
+                    "[locId8=" + U.id8(locNode.id()) + ", locWalMode=" + locWalMode +
+                    ", rmtId8=" + U.id8(n.id()) + ", rmtWalMode=" + rmtWalMode +
+                    ", rmtAddrs=" + U.addressesAsString(n) + ", rmtNode=" + U.toShortString(n) + "]");
+            }
         }
 
         if (log.isDebugEnabled())

modules/core/src/test/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManagerWalModeConsistencyTest.java

@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.managers.discovery;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.configuration.DataStorageConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.configuration.WALMode;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.testframework.GridTestUtils;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Test;
+
+/** Tests for WAL mode consistency validation when nodes join cluster. */
+public class GridDiscoveryManagerWalModeConsistencyTest extends GridCommonAbstractTest {
+    /** */
+    private WALMode walMode;
+
+    /** {@inheritDoc} */
+    @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+        IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
+
+        DataStorageConfiguration dsCfg = new DataStorageConfiguration();
+        dsCfg.setWalMode(walMode).getDefaultDataRegionConfiguration().setPersistenceEnabled(true);
+
+        cfg.setDataStorageConfiguration(dsCfg);
+
+        return cfg;
+    }
+
+    /** {@inheritDoc} */
+    @Override protected void beforeTest() throws Exception {
+        super.beforeTest();
+
+        walMode = null;
+    }
+
+    /** {@inheritDoc} */
+    @Override protected void afterTest() throws Exception {
+        stopAllGrids();
+
+        super.afterTest();
+    }
+
+    /**
+     * Tests that nodes with same WAL mode can join cluster successfully.
+     *
+     * @throws Exception If failed.
+     */
+    @Test
+    public void testSameWalModeJoinsSuccessfully() throws Exception {
+        walMode = WALMode.LOG_ONLY;
+
+        IgniteEx ignite0 = startGrid(0);
+
+        IgniteEx ignite1 = startGrid(1);
+
+        assertEquals(2, ignite0.cluster().nodes().size());
+        assertEquals(2, ignite1.cluster().nodes().size());
+    }
+
+    /**
+     * Tests that nodes with different WAL modes cannot join cluster.
+     *
+     * @throws Exception If failed.
+     */
+    @Test
+    public void testDifferentWalModesCannotJoin() throws Exception {
+        walMode = WALMode.LOG_ONLY;
+
+        IgniteEx ignite0 = startGrid(0);
+
+        walMode = WALMode.FSYNC;
+
+        String errMsg = GridTestUtils.assertThrowsWithCause(() -> startGrid(1), IgniteCheckedException.class)
+            .getCause().getMessage();
+
+        assertTrue(errMsg.startsWith("Remote node has WAL mode different from local") &&
+            errMsg.contains("locWalMode=FSYNC") && errMsg.contains("rmtWalMode=LOG_ONLY"));
+
+        assertEquals(1, ignite0.cluster().nodes().size());
+    }
+}

modules/core/src/test/java/org/apache/ignite/testsuites/IgniteKernalSelfTestSuite.java

@@ -47,6 +47,7 @@
 import org.apache.ignite.internal.managers.deployment.GridDeploymentManagerStopSelfTest;
 import org.apache.ignite.internal.managers.discovery.GridDiscoveryManagerAliveCacheSelfTest;
 import org.apache.ignite.internal.managers.discovery.GridDiscoveryManagerAttributesSelfTest;
+import org.apache.ignite.internal.managers.discovery.GridDiscoveryManagerWalModeConsistencyTest;
 import org.apache.ignite.internal.managers.discovery.IgniteTopologyPrintFormatSelfTest;
 import org.apache.ignite.internal.managers.events.GridEventStorageManagerInternalEventsSelfTest;
 import org.apache.ignite.internal.managers.events.GridEventStorageManagerSelfTest;
@@ -91,6 +92,7 @@
     GridManagerStopSelfTest.class,
     GridDiscoveryManagerAttributesSelfTest.class,
     GridDiscoveryManagerAliveCacheSelfTest.class,
+    GridDiscoveryManagerWalModeConsistencyTest.class,
     GridDiscoveryEventSelfTest.class,
     GridPortProcessorSelfTest.class,
     GridHomePathSelfTest.class,