[codex] Merge remote-tracking branch 'upstream/master' into fix/sink-source-connector-duplicate-open#3264
Closed
MukundaKatta wants to merge 2 commits into
Conversation
The sink_connector! and source_connector! macros silently overwrote an existing INSTANCES entry on a duplicate open call, discarding any in-flight buffered data and orphaning the prior connector tasks. Return -1 on duplicate id so callers see the failure and can drain or close explicitly before re-opening. Closes apache#3168. Signed-off-by: Mukunda Rao Katta <mukunda.vjcs6@gmail.com>
…onnector-duplicate-open
Contributor
Author
|
Closing this duplicate PR in favor of #3265, which carries the same connector SDK duplicate-open fix on the cleaner branch. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3264 +/- ##
============================================
- Coverage 74.10% 73.94% -0.16%
Complexity 943 943
============================================
Files 1159 1182 +23
Lines 102033 108765 +6732
Branches 79083 85969 +6886
============================================
+ Hits 75607 80424 +4817
- Misses 23765 25599 +1834
- Partials 2661 2742 +81
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed files
core/connectors/sdk/src/sink.rscore/connectors/sdk/src/source.rsTests