Skip to content

feat(java): implement Async Connection Pooling using FixedChannelPool #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rythm-sachdeva wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(java): implement Async Connection Pooling using FixedChannelPool #2606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion foreign/java/java-sdk/src/main/java/org/apache/iggy/client/async/tcp/AsyncIggyTcpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import org.apache.iggy.client.async.StreamsClient;
import org.apache.iggy.client.async.TopicsClient;
import org.apache.iggy.client.async.UsersClient;
import org.apache.iggy.client.async.tcp.AsyncTcpConnection.TCPConnectionPoolConfig;
import org.apache.iggy.config.RetryPolicy;
import org.apache.iggy.exception.IggyMissingCredentialsException;
import org.apache.iggy.exception.IggyNotConnectedException;
Expand Down Expand Up @@ -158,7 +159,15 @@ public static AsyncIggyTcpClientBuilder builder() {
* @return a {@link CompletableFuture} that completes when the connection is established
*/
public CompletableFuture<Void> connect() {
connection = new AsyncTcpConnection(host, port, enableTls, tlsCertificate);
TCPConnectionPoolConfig.Builder poolConfigBuilder = new TCPConnectionPoolConfig.Builder();
if (connectionPoolSize.isPresent()) {
poolConfigBuilder.setMaxConnections(connectionPoolSize.get());
}
if (connectionTimeout.isPresent()) {
poolConfigBuilder.setAcquireTimeoutMillis(connectionTimeout.get().toMillis());
}
TCPConnectionPoolConfig poolConfig = poolConfigBuilder.build();
connection = new AsyncTcpConnection(host, port, enableTls, tlsCertificate, poolConfig);
return connection.connect().thenRun(() -> {
messagesClient = new MessagesTcpClient(connection);
consumerGroupsClient = new ConsumerGroupsTcpClient(connection);
Expand Down Expand Up @@ -204,6 +213,10 @@ public UsersClient users() {
return usersClient;
}

public PoolMetrics getTcpConnectionMetrics() {
return this.connection.getMetrics();
}

/**
* Returns the async messages client for producing and consuming messages.
*
Expand Down
Loading