Skip to content

feat(csharp): add iggy error status codes#2519

Open
lukaszzborek wants to merge 7 commits intoapache:masterfrom
lukaszzborek:feature/dotnet-errors
Open

feat(csharp): add iggy error status codes#2519
lukaszzborek wants to merge 7 commits intoapache:masterfrom
lukaszzborek:feature/dotnet-errors

Conversation

@lukaszzborek
Copy link
Contributor

  • add IggyErrorCode enum definition
  • change IggyInvalidStatusCodeException to contains IggyErrorCode
  • add tool to generate enum values from rust error file

@numinnex
Copy link
Contributor

Hi, I've looked through the PR and I really like the idea, but there is one problem tho...

Currently IggyError isn't versioned (e.g it's not an separate crate that adheres to any sane versioning standards), which means that we might change it as we wish (move/remove it, etc..), which means that on an arbitrary release (non major one), we could potentially break the C# SDK.

Since the idea is great, I would like to archive this PR and revisit it once we figure out how to extract our error into an dedicated crate, that we can version independently.

Created #2524 to address that problem.

@lukaszzborek
Copy link
Contributor Author

yep, it might be good idea for hold on it to time where will be separate crate for IggyError. It can be a bit confusing where error code will change in server.

We can also think about some CI checks for thats

@github-actions
Copy link

github-actions bot commented Jan 30, 2026

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either @core on Discord or by mentioning them directly here on the PR.

Thank you for your contribution!

@github-actions github-actions bot added stale and removed stale labels Jan 30, 2026
@github-actions
Copy link

github-actions bot commented Feb 7, 2026

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either @core on Discord or by mentioning them directly here on the PR.

Thank you for your contribution!

@github-actions github-actions bot added the stale label Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants