Spark: Scope Spark CI without ignored path list#16800
Draft
manuzhang wants to merge 1 commit into
Draft
Conversation
Generate the Spark CI matrix from changed version-scoped Spark paths. Fall back to the full matrix for shared or unknown paths instead of duplicating paths-ignore in shell code. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates Spark CI to generate its test matrix from the files changed in a pull request.
For pull requests that only touch version-scoped Spark directories such as
spark/v4.1/**, the workflow now runs only that Spark version's jobs. Changes to shared code, build files, workflow files, docs mixed with Spark changes, or any unknown path continue to run the full Spark matrix.Why
The existing workflow always expands the full Spark matrix once Spark CI is triggered, so a Spark 4.1-only change still runs Spark 4.0 jobs. This keeps coverage for shared changes while avoiding unrelated version-specific test jobs.
The detector intentionally does not duplicate the workflow's
paths-ignorelist. It only narrows the matrix when every changed path is under a version-scoped Spark directory; otherwise it falls back to the full matrix.Validation
.github/workflows/spark-ci.ymlwith Ruby YAML loading.bash -nagainst the generated detector script.spark/v4.1/**selecting only Spark 4.1 jobs.github/workflows/spark-ci.ymlselecting the full matrixspark/v4.1/**selecting the full matrixgit diff --check.actionlintwas not installed locally, so I could not run it before updating the draft PR.