Spec: Clarify decimal type serialization#16798
Open
kevinjqliu wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
Specification
kevinjqliu
force-pushed
the
codex/spec-decimal-format
branch
2 times, most recently
from
47ac3b7 to
cebc038
Compare
kevinjqliu
force-pushed
the
codex/spec-decimal-format
branch
2 times, most recently
from
506217a to
3712561
Compare
kevinjqliu
force-pushed
the
codex/spec-decimal-format
branch
from
3712561 to
f7164c5
Compare
kevinjqliu
changed the title
kevinjqliu
commented
Jun 13, 2026
| font-family: "Source Sans Pro", sans-serif; | ||
| } | ||
|
|
||
| .md-typeset table code { |
Contributor
Author
There was a problem hiding this comment.
need to properly render table cells on the same line, otherwise longer strings like "decimal(P,S)" might be split into multiple lines
| | | **`float`** | [32-bit IEEE 754](https://en.wikipedia.org/wiki/IEEE_754) floating point | Can promote to double | | ||
| | | **`double`** | [64-bit IEEE 754](https://en.wikipedia.org/wiki/IEEE_754) floating point | | | ||
| | | **`decimal(P,S)`** | Fixed-point decimal; precision P, scale S | Scale is fixed, precision must be 38 or less | | ||
| | | **`decimal(P, S)`** | Fixed-point decimal; precision P, scale S | Scale is fixed, precision must be 38 or less | |
Contributor
Author
There was a problem hiding this comment.
changed all decimal(P,S) to decimal(P, S)
| @@ -1679,14 +1675,16 @@ | |||
Contributor
Author
There was a problem hiding this comment.
removed non-canonical example decimal(9,2)
and add a sentence below to explain that readers should accept from without space, decimal(9,2)
ebyhr
reviewed
Jun 14, 2026
ebyhr
left a comment
ebyhr
left a comment
Member
There was a problem hiding this comment.
I feel the readability of the content has decreased. We need to scroll to view the example.
Before
After
singhpk234
reviewed
Jun 14, 2026
| | **`geometry(C)`** |`JSON string: "geometry(<C>)"`|`"geometry(srid:4326)"`| | ||
| | **`geography(C, A)`** |`JSON string: "geography(<C>,<E>)"`|`"geography(srid:4326,spherical)"`| | ||
|
|
||
| The schema JSON type strings in this table are the canonical serialized forms. Readers should accept optional whitespace around parameters and separators in parameterized type strings. |
Contributor
There was a problem hiding this comment.
SHOULD or MUST ?
what are the other lang implementations do ATM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decimal(P, S), matching Java writer output viaDecimalType.toString().Testing
git diff --checksite/make serve-devBefore: https://iceberg.apache.org/spec/#primitive-types
decimal(P,S)and overflows on renderAfter: http://127.0.0.1:8000/spec/#primitive-types
decimal(P, S)and renders on same line