Core: Allow write.metadata.previous-versions-max to be 0#16796
Open
smaheshwar-pltr wants to merge 4 commits into
Open
Core: Allow write.metadata.previous-versions-max to be 0#16796smaheshwar-pltr wants to merge 4 commits into
smaheshwar-pltr wants to merge 4 commits into
Conversation
smaheshwar-pltr
commented
Jun 12, 2026
| | write.summary.partition-limit | 0 | Includes partition-level summary stats in snapshot summaries if the changed partition count is less than this limit | | ||
| | write.metadata.delete-after-commit.enabled | false | Controls whether to delete the oldest **tracked** version metadata files after each table commit. See the [Remove old metadata files](maintenance.md#remove-old-metadata-files) section for additional details | | ||
| | write.metadata.previous-versions-max | 100 | The max number of previous version metadata files to track | | ||
| | write.metadata.previous-versions-max | 100 | The max number of previous version metadata files to track. A value of `0` keeps no previous metadata files (an empty `metadata-log`) | |
Contributor
Author
There was a problem hiding this comment.
Pointing out that I'm not including a spec change in this PR because I kind of think
A list (optional) of timestamp and metadata file location pairs that encodes changes to the previous metadata files for the table. Each time a new metadata file is created, a new entry of the previous metadata file location should be added to the list. Tables can be configured to remove oldest metadata log entries and keep a fixed-size log of the most recent entries after a commit.
from https://iceberg.apache.org/spec/#table-metadata is worded consistently with a value of 0?
smaheshwar-pltr
added a commit
to smaheshwar-pltr/iceberg
that referenced
this pull request
Jun 13, 2026
…ded-file delete Addresses review on PR apache#16796: drop the trackedMetadataFiles helper and restore the original entry-level removeAll (MetadataLogEntry equality) over Sets.newHashSet(base.previousFiles()), with the original comment. The max=0 behaviour is now an explicitly-guarded additive step: delete base's superseded metadata file only when the new metadata no longer references it (not its current location and not in its log). This keeps the method a no-op for previous-versions-max >= 1 and for base == metadata (a public-API contract the helper version regressed), and is null-safe. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pins the public-API contract that the superseded-file deletion must never remove the live current metadata file: with base and metadata sharing a location and an empty log (the previous-versions-max=0 shape), nothing is deleted. This guards the !superseded.equals(metadata.metadataFileLocation()) condition, which no existing test covered. The null-base-location path is already exercised by noFailureWhenBulkDeletingMetadataFiles, so no separate test is added for it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
smaheshwar-pltr
force-pushed
the
previous-versions-max-zero
branch
from
85e3b32 to
98ea1dd
Compare
smaheshwar-pltr
commented
Jun 13, 2026
| int maxSize = | ||
| Math.max( | ||
| 1, | ||
| 0, |
Contributor
Author
There was a problem hiding this comment.
Pointing out that a negative value for this property now corresponds to an empty log - previously, it was a log of maximum size one. This is technically a break, but that felt fine to me?
Open
3 tasks
smaheshwar-pltr
changed the title
smaheshwar-pltr
commented
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16797, if folks are aligned with that feature request in the first place (please let me know your thoughts there!)