Common: Handle NoClassDefFoundError during optional Dyn* class loading#16793
Open
nastra wants to merge 1 commit into
Open
Common: Handle NoClassDefFoundError during optional Dyn* class loading#16793nastra wants to merge 1 commit into
nastra wants to merge 1 commit into
Conversation
nastra
force-pushed
the
dyn-classes-noclassdeffound
branch
3 times, most recently
from
567cf39 to
919b79e
Compare
wombatu-kun
reviewed
Jun 13, 2026
wombatu-kun
reviewed
Jun 13, 2026
wombatu-kun
reviewed
Jun 13, 2026
nastra
force-pushed
the
dyn-classes-noclassdeffound
branch
from
919b79e to
6579a0a
Compare
wombatu-kun
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the
Dyn*classes useClass.forName(className, true, loader)and catchClassNotFoundExceptionwhen probing for optional implementations by class name, butClass.forNamecan also throwNoClassDefFoundErrorwhen the class itself is found but one of its transitive dependencies is missing. It can also throwExceptionInInitializerErrorwhen the static initializer of the loaded class fails.We're intentionally not handling
ExceptionInInitializerErrorand propagate it to the caller.The PR was created with the help of Claude Code