Core: skip reading large manifest entry fields when not used in ManifestFilterManager#16281
Draft
grantatspothero wants to merge 1 commit intoapache:mainfrom
Draft
Core: skip reading large manifest entry fields when not used in ManifestFilterManager#16281grantatspothero wants to merge 1 commit intoapache:mainfrom
grantatspothero wants to merge 1 commit intoapache:mainfrom
Conversation
grantatspothero
force-pushed
the
gn/manifestFilterManager
branch
from
10fb633 to
72f9947
Compare
manifestHasDeletedFiles doesn't read manifest stats when deleteExpression not set
grantatspothero
changed the title
grantatspothero
force-pushed
the
gn/manifestFilterManager
branch
from
72f9947 to
9c0a662
Compare
Contributor
Author
|
The ReplaceDeleteFilesBenchmark doesn't show a difference because it reads files from manifests before passing them to rewriteFiles, so manifestLocation is populated. This triggers the optimization from #11131 that skips scanning manifests entirely. Some compaction implementations cannot preserve manifestLocation. Any time a content file is serialized/passed across the wire it loses manifestLocation and thus the optimization will never trigger. And there is no public API to set manfestLocation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During MergingSnapshotProducer commits, ManifestFilterManager reads and materializes every ManifestEntry in a table to determine if manifests need to be rewritten. However, the common case is only a small fraction of manifests are modified in a commit.
There is already an optimization in place to avoid rewriting manifests which are unchanged, but this PR further improves that optimization by only projecting a lightweight manifestentry that doesn't include stats.