-
Notifications
You must be signed in to change notification settings - Fork 3k
Add Flink quickstart #15062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Flink quickstart #15062
Conversation
…pl will commonly look for it
MartijnVisser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thnx for the PR, I've checked the Flink input and left some minor nits, but overall +1
| s3.secret-key: password | ||
| s3.endpoint: http://seaweedfs:9000 | ||
| s3.path.style.access: true | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could choose to add a sql-client implementation here too, like
sql-client:
image: flink:latest
depends_on:
- jobmanager
command: bin/sql-client.sh
environment:
- |
FLINK_PROPERTIES=
jobmanager.rpc.address: jobmanager
rest.address: jobmanager
That you could then run via docker compose run sql-client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd erred towards a more concise set of containers—but I'm happy to make this change if you'd prefer?
| Launch a Flink SQL client session: | ||
|
|
||
| ```sh | ||
| docker compose exec -it jobmanager ./bin/sql-client.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the above suggestion, this could be replaced by docker compose run sql-client
This is modelled on the existing Spark quickstart.
It uses a Docker Compose and Dockerfile; I've put these under
/flink/v2.0/quickstartin the repo, but not sure if that's the right location :)