Build: Bump roaringbitmap from 1.3.0 to 1.6.0 #14991
Conversation
manuzhang
force-pushed
the
upgrade-roaringbitmap
branch
from
a0f2b0f to
9b38f3d
Compare
manuzhang
force-pushed
the
upgrade-roaringbitmap
branch
from
9b38f3d to
37dee6b
Compare
manuzhang
changed the title
manuzhang
force-pushed
the
upgrade-roaringbitmap
branch
from
37dee6b to
cd3e65b
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the RoaringBitmap dependency from version 1.3.0 to 1.6.0, migrating from Maven Central (org.roaringbitmap:RoaringBitmap) to JitPack (com.github.RoaringBitmap.RoaringBitmap:roaringbitmap) as the publishing location changed after version 1.3.0.
Key Changes:
- Updated RoaringBitmap version from 1.3.0 to 1.6.0 in the version catalog
- Changed the Maven coordinates from
org.roaringbitmap:RoaringBitmaptocom.github.RoaringBitmap.RoaringBitmap:roaringbitmap - Updated relocation paths in all Spark runtime build files to reflect the new package structure
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updated RoaringBitmap version to 1.6.0 and changed Maven coordinates to JitPack format |
| spark/v4.1/build.gradle | Added exclusion for old org.roaringbitmap group and updated relocation path for new package structure |
| spark/v4.0/build.gradle | Updated relocation path to match new RoaringBitmap package structure |
| spark/v3.5/build.gradle | Updated relocation path to match new RoaringBitmap package structure |
| spark/v3.4/build.gradle | Updated relocation path to match new RoaringBitmap package structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM the gradle usage is documented at https://github.com/RoaringBitmap/RoaringBitmap?tab=readme-ov-file#usage-within-a-gradle-project
Not sure if there's additional considerations when adding a new custom Maven repository, we should double check that
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
I think we'll need to double check any LICENSE contents that needs to be updated as well, looks like KC and the open API modules would need to be updated
|
@amogh-jahagirdar Updated LICENSE files. BTW, do you know why the LICENSE file in Filnk doesn't have version with it? |
manuzhang
force-pushed
the
upgrade-roaringbitmap
branch
from
39d7b65 to
f6d39d5
Compare
spark/v4.1/build.gradle
Outdated
| integrationImplementation ("org.apache.spark:spark-hive_${scalaVersion}:${libs.versions.spark41.get()}") { | ||
| exclude group: 'org.roaringbitmap' | ||
| } |
There was a problem hiding this comment.
Is this exclusion strictly required? Or are we just trying to slim down the spark-hive test dependencies?
There was a problem hiding this comment.
Otherwise, there will be two versions of Roaringbitmap on the test classpath.
There was a problem hiding this comment.
That makes sense, though is this not an issue also for the other spark versions? Did something get changed specifically within 4.1?
There was a problem hiding this comment.
Nice catch! I forgot to update for other Spark versions as well.
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Just had a question on why the exclusion is required, but other than that looks OK to me.
No, tbh I don't know why Flink doesn't track the explicit version. I don't think it's strictly required, at least as per https://infra.apache.org/licensing-howto.html#alv2-dep but yeah it is inconsistent with the other modules.
manuzhang
force-pushed
the
upgrade-roaringbitmap
branch
from
f6d39d5 to
ca29f72
Compare
manuzhang
force-pushed
the
upgrade-roaringbitmap
branch
from
ca29f72 to
ad01e6b
Compare
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Thanks @manuzhang! since it's a fairly critical dependency I'll give it another day for other people to chime in before merging.
3 participants
roaringbitmap was no longer published to https://mvnrepository.com/artifact/org.roaringbitmap/RoaringBitmap after 1.3.0, but to https://jitpack.io as
com.github.RoaringBitmap.RoaringBitmap:roaringbitmap