site: fix live loading in make serve-dev
#14978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
approved these changes
Jan 7, 2026
Contributor
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14524
I found the underlying issue while looking at a similar fix for pyiceberg (apache/iceberg-python#2889)
This PR adds the
--livereloadflag to force live reload.This PR also removes the
--dirtyflag so reload works with changes tosite/mkdocs-dev.ymlandsite/overrides/. Even after removing the--dirtyflag, reloading takes ~10 seconds which is acceptable.I tested this manually by making changes to varies files and reloading :)