Make StandardEncryptionManager serializable #14751
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
|
cc @ggershinsky |
Contributor
|
In general, sounds good to me. The security model of Iceberg table encryption does not preclude distribution of the encryption manager and the kms client. |
ggershinsky
reviewed
Dec 8, 2025
aws/src/main/java/org/apache/iceberg/aws/AwsKeyManagementClient.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/encryption/StandardEncryptionManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/encryption/BaseEncryptedKey.java
Outdated
Show resolved
Hide resolved
…well/encrypted-serializable # Conflicts: # core/src/main/java/org/apache/iceberg/encryption/StandardEncryptionManager.java
tom-s-powell
commented
Jan 8, 2026
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestTableEncryption.java
Show resolved
Hide resolved
Contributor
Author
|
@huaxingao okay with this one? |
huaxingao
reviewed
Jan 16, 2026
core/src/main/java/org/apache/iceberg/encryption/BaseEncryptedKey.java
Outdated
Show resolved
Hide resolved
Contributor
|
LGTM except a minor comment. |
Contributor
|
@ggershinsky @smaheshwar-pltr Do you have any more comments for this PR? |
singhpk234
reviewed
Jan 16, 2026
aws/src/integration/java/org/apache/iceberg/aws/TestKeyManagementClient.java
Outdated
Show resolved
Hide resolved
azure/src/main/java/org/apache/iceberg/azure/keymanagement/AzureKeyManagementClient.java
Outdated
Show resolved
Hide resolved
gcp/src/main/java/org/apache/iceberg/gcp/GcpKeyManagementClient.java
Outdated
Show resolved
Hide resolved
smaheshwar-pltr
approved these changes
Jan 16, 2026
Contributor
smaheshwar-pltr
left a comment
smaheshwar-pltr
left a comment
There was a problem hiding this comment.
LGTM too, only nits. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StandardEncryptionManagerandKeyManagementClientare already declared asSerializablebut they are not actually serializable. This breaks use ofEncryptingFileIOwith certain things such asAllManifestsTableScan.#14750 will ensure key ids are preserved.