-
Notifications
You must be signed in to change notification settings - Fork 3k
DOC: Add REST catalog authentication properties documentation #14143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a new section documenting REST catalog authentication properties including: - Authentication types (none, basic, oauth2, sigv4, google) - Basic authentication properties - OAuth2 authentication properties - Token management properties This addresses issue apache#13209 by providing comprehensive documentation for REST catalog authentication configuration.
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
| | audience | null | Optional audience parameter for OAuth2 | | ||
| | resource | null | Optional resource parameter for OAuth2 | | ||
| | rest.auth.sigv4.delegate-auth-type| oauth2 | Delegate auth type for SigV4 authentication | | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For google we need to also document these:
iceberg/gcp/src/main/java/org/apache/iceberg/gcp/auth/GoogleAuthManager.java
Lines 56 to 57 in 40c0a73
| public static final String GCP_CREDENTIALS_PATH_PROPERTY = "gcp.auth.credentials-path"; | |
| public static final String GCP_SCOPES_PROPERTY = "gcp.auth.scopes"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact I would probably extract this into its own small table that is specific to google. Then we should do the same for oauth2 and the other auth types
|
I just realized that there's also #14065, which does the same thing and was opened a while earlier than this PR. I think we should close this one and get 14065 in |
|
I'll go ahead and close this one since #14065 got merged |
Add a new section documenting REST catalog authentication properties including:
This addresses issue #13209 by providing comprehensive documentation for REST catalog authentication configuration.