feat(encryption): [11/N] KMS factory trait and catalog wiring#2650
Open
xanderbailey wants to merge 2 commits into
Open
feat(encryption): [11/N] KMS factory trait and catalog wiring#2650xanderbailey wants to merge 2 commits into
xanderbailey wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Adds
KmsClientFactoryto the catalog builder to allow a catalog to build one KMS client per catalog, this mirrors Java's implementation . Note in rust we don't have reflection so using Java'sencryption.kms-implisn't an option for us. This is a very similar pattern to what we do for theStorageFactoryso I believe the pattern is idiomatic for us.Are these changes tested?