Rewrite + Validation + ManifestFilter #2620
Draft
CTTY wants to merge 2 commits into
Draft
Conversation
CTTY
commented
Jun 11, 2026
CTTY
left a comment
CTTY
left a comment
Collaborator
Author
There was a problem hiding this comment.
Java's ManifestFilterManager allows you to cache across multiple commit attempts. Since we only store transaction actions in a Transaction, we cannot do that easily. I haven't got a chance to think deeply on that
| /// durable state lives within a single filtering pass, which matches the operation's | ||
| /// per-attempt lifetime (it is reconstructed deterministically on each commit retry). | ||
| #[derive(Debug, Default)] | ||
| pub(crate) struct ManifestFilterManager { |
Collaborator
Author
There was a problem hiding this comment.
Just a placeholder for now
| // files/entries to drop, drop predicate, within-pass tracking, ... | ||
| } | ||
|
|
||
| impl ManifestFilterManager { |
Collaborator
Author
There was a problem hiding this comment.
This is a placeholder for now, we will need to add more concrete methods
| deleted_delete_files: self.deleted_delete_files.clone(), | ||
| starting_snapshot_id: self.starting_snapshot_id, | ||
| data_sequence_number: self.data_sequence_number, | ||
| data_filter: ManifestFilterManager::default(), |
Collaborator
Author
There was a problem hiding this comment.
I don't think this will be enough, the actual filter manager implementation will need to have file io and related states
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?