Skip to content

chore(refactor): rename SnapshotProducer::manifest_file to produce_manifest_file_list #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dannycjones wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(refactor): rename SnapshotProducer::manifest_file to produce_manifest_file_list #2596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions crates/iceberg/src/transaction/snapshot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,10 @@ impl<'a> SnapshotProducer<'a> {
writer.write_manifest_file().await
}

async fn manifest_file<OP: SnapshotProduceOperation, MP: ManifestProcess>(
/// Collects the list of manifest files to be included in the new snapshot.
///
/// This method also writes the new manifests where required.
async fn produce_manifest_file_list<OP: SnapshotProduceOperation, MP: ManifestProcess>(
&mut self,
snapshot_produce_operation: &OP,
manifest_process: &MP,
Expand Down Expand Up @@ -475,7 +478,7 @@ impl<'a> SnapshotProducer<'a> {
})?;

let new_manifests = self
.manifest_file(&snapshot_produce_operation, &process)
.produce_manifest_file_list(&snapshot_produce_operation, &process)
.await?;

manifest_list_writer.add_manifests(new_manifests.into_iter())?;
Expand Down
Loading