feat(catalog): Implement update_table for Hive metastore catalog #1894
+396
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladson
force-pushed
the
hms_update_table
branch
from
3ffd73b to
b5c3d53
Compare
Partial implementation of HMS traditional commit stabilising fix issues with hms lock flow refactoring for optimistic locks address format
vladson
force-pushed
the
hms_update_table
branch
from
b5c3d53 to
bc562b7
Compare
Author
|
Hi team, I would appreciate it if anyone could take a look at the PR, it's my first in iceberg-rust, but I hope it is in the spirit of the project. |
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @vladson for this pr, just finished first round of review.
| metainfo = { workspace = true } | ||
| motore-macros = { workspace = true } | ||
| volo = { workspace = true } | ||
| whoami = "1.6.1" |
Contributor
There was a problem hiding this comment.
We manage dependencies in workspace's root cargo.tom.
| let db_name = validate_namespace(ident.namespace())?; | ||
| let tbl_name = ident.name.clone(); | ||
|
|
||
| if self.config.props.contains_key(HMS_HIVE_LOCKS_DISABLED) { |
Contributor
There was a problem hiding this comment.
I'm not a hive expert, but I would suggest to start with pessimistic version only first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
update_table for HMS catalog.
The implementation is based on other iceberg implementations, Trino and Hive code bases.
Are these changes tested?
The existing tests were modified, and extensive manual tests were performed.