fix(rest): handle empty body in AWS SigV4 signing #2827
+72
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
reviewed
Dec 24, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
thanks for the PR! could you provide some context around this change? and perhaps a test
plusplusjiajia
force-pushed
the
fix-sigv4
branch
from
750b14b to
1ef9f2f
Compare
plusplusjiajia
force-pushed
the
fix-sigv4
branch
from
1ef9f2f to
d595859
Compare
Member
Author
This change is made to align with the behavior of the Java version, can you help check whether the change is reasonable?https://github.com/apache/iceberg/blob/main/aws/src/main/java/org/apache/iceberg/aws/RESTSigV4AuthSession.java#L116 |
plusplusjiajia
force-pushed
the
fix-sigv4
branch
3 times, most recently
from
df984c9 to
2b42e66
Compare
plusplusjiajia
force-pushed
the
fix-sigv4
branch
from
2b42e66 to
4d0615f
Compare
Fokko
approved these changes
Jan 5, 2026
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Thanks for adding the reference to the Java code, this change looks good to me 👍
Co-authored-by: Fokko Driesprong <fokko@apache.org>
geruh
approved these changes
Jan 15, 2026
Contributor
geruh
left a comment
geruh
left a comment
There was a problem hiding this comment.
LGTM! The fix is correct, and aligns with the Java impl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The x-amz-content-sha256 header is required for AWS requests. It provides a hash of the request payload. If there is no payload, you must provide the hash of an empty string.
Are these changes tested?
Are there any user-facing changes?